From 1b3502c62a9e32dc6830aeb3d020748d9b443151 Mon Sep 17 00:00:00 2001 From: Chanwoong Park <128444378+chanchanwoong@users.noreply.github.com> Date: Sun, 23 Jun 2024 23:24:43 +0900 Subject: [PATCH] =?UTF-8?q?refactor:=20=EC=9E=85=EC=B0=B0=20=EA=B2=80?= =?UTF-8?q?=EC=82=AC=20=EC=9D=B8=EC=9E=90=EC=97=90=20auctionUuid=20?= =?UTF-8?q?=EC=B6=94=EA=B0=80(#210)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../auction/application/impl/AuctionServiceImpl.java | 8 +++++--- .../auction/repository/AuctionHistoryRepository.java | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/main/java/com/skyhorsemanpower/auction/application/impl/AuctionServiceImpl.java b/src/main/java/com/skyhorsemanpower/auction/application/impl/AuctionServiceImpl.java index 2833246..56ea4e1 100644 --- a/src/main/java/com/skyhorsemanpower/auction/application/impl/AuctionServiceImpl.java +++ b/src/main/java/com/skyhorsemanpower/auction/application/impl/AuctionServiceImpl.java @@ -196,7 +196,8 @@ private void isBiddingPossible(OfferBiddingPriceDto offerBiddingPriceDto, RoundI log.info("입찰 시간 통과"); // 조건2. 해당 라운드에 참여 여부 - checkBiddingRound(offerBiddingPriceDto.getBiddingUuid(), offerBiddingPriceDto.getRound()); + checkBiddingRound(offerBiddingPriceDto.getAuctionUuid(), offerBiddingPriceDto.getBiddingUuid(), + offerBiddingPriceDto.getRound()); log.info("현재 라운드에 참여한 적 없음"); // 조건3. 남은 인원이 1 이상 @@ -208,8 +209,9 @@ private void isBiddingPossible(OfferBiddingPriceDto offerBiddingPriceDto, RoundI log.info("라운드 및 입찰가 통과"); } - private void checkBiddingRound(String biddingUuid, int round) { - if (auctionHistoryRepository.findByBiddingUuidAndRound(biddingUuid, round).isPresent()) { + private void checkBiddingRound(String auctionUuid, String biddingUuid, int round) { + if (auctionHistoryRepository.findByAuctionUuidAndBiddingUuidAndRound( + auctionUuid, biddingUuid, round).isPresent()) { throw new CustomException(ResponseStatus.ALREADY_BID_IN_ROUND); } } diff --git a/src/main/java/com/skyhorsemanpower/auction/repository/AuctionHistoryRepository.java b/src/main/java/com/skyhorsemanpower/auction/repository/AuctionHistoryRepository.java index ce8e603..f6da539 100644 --- a/src/main/java/com/skyhorsemanpower/auction/repository/AuctionHistoryRepository.java +++ b/src/main/java/com/skyhorsemanpower/auction/repository/AuctionHistoryRepository.java @@ -23,7 +23,7 @@ public interface AuctionHistoryRepository extends MongoRepository findByAuctionUuidAndRoundOrderByBiddingTime(String auctionUuid, int round); - Optional findByBiddingUuidAndRound(String biddingUuid, int round); + Optional findByAuctionUuidAndBiddingUuidAndRound(String auctionUuid, String biddingUuid, int round); Optional findFirstByAuctionUuidOrderByBiddingTimeDesc(String auctionUuid); }