Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we disable CRLF->LF in formatter? #361

Open
slaymaker1907 opened this issue May 5, 2017 · 1 comment
Open

Should we disable CRLF->LF in formatter? #361

slaymaker1907 opened this issue May 5, 2017 · 1 comment
Assignees
Labels
Milestone

Comments

@slaymaker1907
Copy link
Collaborator

If you have git setup on Windows to convert LF to CRLF, running format creates a huge diff even though nothing really changed. If we set tsfmt to not change the line endings, then that will make it simpler here but could make us end up with a bunch of bad line endings.

I'm wondering if we could configure our git repo to automatically do the conversion and not worry about it in tsmft?

@slaymaker1907 slaymaker1907 added this to the 2.0 milestone May 5, 2017
@cj-dimaano
Copy link
Member

I think if we can get GitHub to enforce LF over CRLF, then I'm for getting rid of the tsfmt rule. However, I believe the configuration of the git tool on Windows depends on the user, but I'm not too sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants