Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeyBinding issues for Windows/Linux #315

Open
danielscottjames opened this issue Apr 21, 2017 · 2 comments
Open

KeyBinding issues for Windows/Linux #315

danielscottjames opened this issue Apr 21, 2017 · 2 comments
Assignees
@danielscottjames @cj-dimaano
Labels
bug Linux Windows
Milestone
2.0

Comments

@danielscottjames
Copy link
Member

Related to #155 #162

Basically, menu shortcuts don't work as expected in Windows. This will probably require collaboration with me and @cj or if I have time, I'll setup a VM.
@danielscottjames danielscottjames added this to the 1.0 milestone Apr 21, 2017
This was referenced Apr 21, 2017
Closed
Closed
@cj-dimaano
Copy link
Member

This is also present on Linux.

@cj-dimaano cj-dimaano changed the title KeyBinding issues for Windows KeyBinding issues for Windows/Linux Apr 24, 2017
@danielscottjames danielscottjames modified the milestones: 2.0, 1.0 Apr 25, 2017
@danielscottjames
Copy link
Member Author

This is going to require rethinking how we're capturing the menu events. Because Chromium/Electron apparently special case some shortcuts and we can't override them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielscottjames danielscottjames

@cj-dimaano cj-dimaano

Labels
bug Linux Windows
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@danielscottjames @cj-dimaano