Modified settings not saved when saving general setting

[unclej84]

When making changes to the settings they are not saved using save button in the general settings window. They are only saved if e.g. a web hook is deleted. Also when a template is loaded the settings are saved. So when just editing something the test still sends the old settings.
Or is there any button for saving modifications to web hook which I cannot find?

[derekantrican]

+1 I have noticed this too

[anthonylavado]

I have noticed this is resetting a lot of my stuff.

[2blane]

This seems like a consistent issue. Looking into this.

[Ruthalas]

Still an issue.
I struggled to save any settings, though creating and deleting a new webhook worked ~50% of the time.
Is it intended to save settings on the general settings save, or when the user leaves a text field?

This plugin seems to work quite well aside from this.

[derekantrican]

@2blane any update on this? Seems like a "consistent issue" of not being able to save settings should get fixed a lot faster than 2 years.

[derekantrican]

@unclej84 @anthonylavado @Ruthalas @jescholl (from the thumbs up on the original report)

I have taken over the plugin and the new repo is now here: https://github.com/derekantrican/OctoPrint-Webhooks . I have also (just today) fixed some issue with saving the settings. Would you mind giving it a try and seeing if it works for you? I'd like to know if you are still seeing this issue. You should just be able to upgrade your plugin in octoprint to 3.2.0 - let me know if you have questions.

[unclej84]

@derekantrican sorry, I have replaced the plugin by an other solution so I cannot test.