Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Webhook calls for single event. #15

Open
xrxca opened this issue Aug 30, 2020 · 6 comments
Open

Multiple Webhook calls for single event. #15

xrxca opened this issue Aug 30, 2020 · 6 comments

Comments

@xrxca
Copy link

xrxca commented Aug 30, 2020

I haven't looked all that far into this issue, but when my printers pauses for a color change it triggers the webhook every two seconds till I get to the printer.
Since the hook in question is on my own server, I was able to check the logs, on two different prints with a color change part way, on one there were 285 calls, on the other only 97 (I was on the same floor)

My server just validates the call from a machine on the local network then sends a text message using an online service, since I've seen this bad behavior in other apps, my server has a limit (same message repeated within 15 minutes won't get sent) but if I'd set it up to trigger directly on the cloud service I'd have had almost 400 messages sent.

Is this a function of the return value from the webpage, that I can control/change if necessary, something else in Octoprint, or a bug in the plugin?.

There should probably some kind of a throttle.

@2blane
Copy link
Owner

2blane commented Nov 4, 2020

I have seen this issue before. I think I have a solution, but it's more of a throttle. Will throttle it back to a message every 5 minutes.

@DaveTSG
Copy link

DaveTSG commented Mar 7, 2021

For what it's worth, I'm experiencing this too. (I've only recently installed the plugin)
OctoPrint 1.5.3, Webhooks v3.0.3, Python 2.7.16.

When I start a print, I get almost a dozen "print started" notifications, and also a "user action needed" notification at the same time.

Other notifications work fine, e.g. print finished I only get one notification, and expected user action needed events (e.g. changing filament) also only results in one notification.

Happy to provide further details if you let me know what's needed... :)

@MildMastermind
Copy link

I had the same issue the other day when my printer paused for the first time after installing this. I suspect the printer firmware just spams the "print paused", and there is nothing in the plugin to handle the spamming.

@nicholaskillin
Copy link

I just ran into this as well. The user action needed action is pretty bad, sending TONS of Webhooks when triggered.

It also looks like this repo hasn't seen any updates in a while. Is this still being maintained, or should I look for other solutions?

@edm00se
Copy link

edm00se commented Sep 10, 2022

I also get this with a "print paused" event; endless duplicate messages until I disable the plugin entirely. The other events seem fine to me.

@derekantrican
Copy link

This is now being tracked in the new repo here: derekantrican#5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants