modify ISP pipeline for better image quality #15
Conversation
sjbgg
commented
Apr 17, 2023
sjbgg
commented
- move the nr2d module before local contrast and sharpen(currently empty), so that final images can get better details
- modified requirements.txt, removed specific version, tested fine
1. move the nr2d module before local contrast and sharpen, so that final images can get better details 2. modified requirements.txt, removed specific version, tested fine
|
Thanks @sjbgg. Will test the quality of the new pipeline on a few more images before accepting the PR. |
There was a problem hiding this comment.
@sjbgg the requirements.txt file is generated automatically using the gen_requirements.py file without any manual tweaking. It gives a good reference of the library versions on which the pipeline will certainly run. A user can use this requirements.txt to install the exact versions of libraries on which the pipeline will run using the how-to-run guide.
There was a problem hiding this comment.
I see. I ran into some problems while installing so I deleted all the version numbers. And it automatically installed the latest version from the server.
I agree the version numbers are good for reference though.
|
PR is outdated now after pipeline Version 1.1 Upgrade |
