Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The plugin hasn't been tested with an upcoming version of WordPress #217

Closed
github-actions bot opened this issue Jul 1, 2024 · 4 comments · Fixed by #218
Closed

The plugin hasn't been tested with an upcoming version of WordPress #217

github-actions bot opened this issue Jul 1, 2024 · 4 comments · Fixed by #218
Assignees
Labels
Milestone

Comments

@github-actions
Copy link

github-actions bot commented Jul 1, 2024

There is an upcoming WordPress version in the release candidate stage that the plugin hasn't been tested with. Please test it and then change the "Tested up to" field in the plugin readme.

Tested up to: 6.5
Upcoming version: 6.6

This issue will be closed automatically when the versions match.

@github-actions github-actions bot added the wpvc label Jul 1, 2024
@vikrampm1 vikrampm1 moved this from Incoming to To Do in Open Source Practice Jul 1, 2024
@jeffpaul jeffpaul added this to the 1.2.0 milestone Jul 1, 2024
@sudip-md sudip-md self-assigned this Jul 2, 2024
@sudip-md
Copy link
Contributor

sudip-md commented Jul 3, 2024

@vikrampm1 @jeffpaul I have tested Maps for Block Apple plugin against 6.6 and it is working as expected.

Environment

WordPress: 6.6-RC1-58590
PHP: 8.1.23
Server: nginx/1.16.0
Database: mysqli (Server: 8.0.16 / Client: mysqlnd 8.1.23)
Browser: Chrome 126.0.0.0 (macOS)
Theme: Twenty Twenty Four 1.1

Plugins:
Block for Apple Maps 1.1.3
WordPress Beta Tester 3.5.5

@sudip-md sudip-md assigned vikrampm1 and unassigned sudip-md Jul 3, 2024
@vikrampm1
Copy link

@sudip-md We have another task that we want to verify/update as part of these bumps #216. Can you check if you can able to work on those updates or if you need any help from the engineering?

@vikrampm1 vikrampm1 assigned sudip-md and unassigned vikrampm1 Jul 3, 2024
@jeffpaul jeffpaul moved this from To Do to Code Review in Open Source Practice Jul 5, 2024
@jeffpaul
Copy link
Member

jeffpaul commented Jul 5, 2024

@sudip-md @fabiankaegy note that the related PR to bump the WP version, #218, has e2e tests failing so I'm not sure if that's an issue with the tests or if the plugin actually doesn't pass automated tests on WP. So worth checking those specifics in any case.

@sudip-md
Copy link
Contributor

sudip-md commented Jul 8, 2024

@jeffpaul Now, There seems to be no problem with #218 because all checks pass

@sudip-md sudip-md removed their assignment Jul 8, 2024
@github-project-automation github-project-automation bot moved this from Code Review to Done in Open Source Practice Jul 9, 2024
@dkotter dkotter modified the milestones: 1.2.0, 1.1.4 Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants